Tracking PR for updated build method #1
Conversation
| @@ -0,0 +1,3 @@ | |||
| [submodule "pybind11"] | |||
| path = pybind11 | |||
| url = https://github.com/pybind/pybind11.git | |||
There was a problem hiding this comment.
Is there a way to pin the version of pybind? Otherwise, this module will break as soon as there are breaking changes introduced into pybind11.
There was a problem hiding this comment.
Oh interesting, last time I added the submodule to another package it pinned it to a particular commit hash. I can do that
| subprocess.check_call(['cmake', '--build', '.'] + build_args, cwd=self.build_temp) | ||
|
|
||
|
|
||
| setup( |
There was a problem hiding this comment.
Could you please update the following properties accordingly (or do you want me to update them)?
As far as I could see, there is no breaking change in the public interface, so we can simply bump the version to 1.0.3 (I'd do that in a separate pull request)?
There was a problem hiding this comment.
Sure. I added them in haste as I needed something working for a project. Will update them accordingly and bump version.
That would be great! Can we maybe do that in a separate pull request? |
Sure. I've had decent luck with AppVeyor (e.g. https://github.com/safijari/apriltags2_ethz/). I'd need you to set up your pypi credentials as a secret in appveyor or whatever we end up using. Either that or I'd need to be a collaborator for the lanms package on PyPI. |
It's probably most secure to set up pypi token credentials. Would appveyor still be your preferred platform? |
So, I've set this up with a CMake file, made pybind11 into a submodule, etc. All this set up will let me build self contained wheels (manylinux) across a large number of python versions, which I'll be temporarily publishing to PyPI under lanms-proper. If you're interested in incorporating this and having CI set up to build and publish the wheels automatically please comment here and I can move this PR forward with those changes.